ResponseBuilder class. #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't really understand the purpose of such builder ? Why not using a response factory or directly the response ? |
|
@joelwurtz, we have response factory which can do this? The purpose is reuse of implementation independent code. It was discussed in original PR. Parsing headers is a common task for HTTP client (similar code in socket and curl clients). Also it can be used by third-party libs. For example I need to create HttpMessage instances from HTTP dumps and so can use this functionality. |
|
Hum didn't read well the code, my bad ^^ LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client-tools repo was removed, so I recreated PR for ResponseBuilder here.
Not sure about spec file because I'm not familiar with PhpSpec.